Skip to content

feat: Bring back previous announcement style #35672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 9 commits into from
Apr 4, 2025
Merged

feat: Bring back previous announcement style #35672

kodiakhq merged 9 commits into from
Apr 4, 2025

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 1, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

image

After trying a new approach in the announcement for rooms, the design team decided to bring back the previous style in the enhanced navigation feature preview

Issue(s)

Steps to test or reproduce

  • Enable the Enhanced Navigation Experience feature preview
  • Create a room
  • Add a announcement
  • Check the announcement banner next to the room header

Further comments

SIDE2-17

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 1, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 73d02b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/ui-client Major
@rocket.chat/meteor Minor
@rocket.chat/gazzodown Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 7.6.0 milestone Apr 1, 2025
@dougfabris dougfabris force-pushed the feat/announcement-banner branch from b96fc15 to c766e85 Compare April 1, 2025 18:34
@dougfabris dougfabris force-pushed the feat/announcement-banner branch from ce121c6 to 4fc972a Compare April 3, 2025 00:36
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35672/

Built to branch gh-pages at 2025-04-04 18:37 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (a486016) to head (73d02b5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35672      +/-   ##
===========================================
+ Coverage    59.62%   59.63%   +0.01%     
===========================================
  Files         2830     2832       +2     
  Lines        68297    68299       +2     
  Branches     15134    15130       -4     
===========================================
+ Hits         40719    40732      +13     
+ Misses       24969    24958      -11     
  Partials      2609     2609
Flag Coverage Δ
unit 75.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review April 3, 2025 14:12
@dougfabris dougfabris requested a review from a team as a code owner April 3, 2025 14:12
@dougfabris dougfabris force-pushed the feat/announcement-banner branch from 1eef6bc to 709edb0 Compare April 3, 2025 14:20
juliajforesti
juliajforesti requested changes Apr 4, 2025
View reviewed changes
@dougfabris dougfabris force-pushed the feat/announcement-banner branch from 709edb0 to 55f66d8 Compare April 4, 2025 18:29
@dougfabris dougfabris requested a review from juliajforesti April 4, 2025 19:32
juliajforesti
juliajforesti requested changes Apr 4, 2025
View reviewed changes
@dougfabris dougfabris force-pushed the feat/announcement-banner branch from 2cb6081 to 73d02b5 Compare April 4, 2025 20:26
@dougfabris dougfabris requested a review from juliajforesti April 4, 2025 20:26
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Apr 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2025
@kodiakhq kodiakhq bot merged commit 72725d3 into develop Apr 4, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the feat/announcement-banner branch April 4, 2025 21:02
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Apr 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliajforesti juliajforesti juliajforesti approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dougfabris @juliajforesti